Allow to specify an indices stats condition #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we expand the existing `indices-stats` operation and allow to pass a condition based on a path and an expected value. This has a variety of use cases: * Verify that the number of documents in an index matches the expected number of documents * Wait until an operation has finished (e.g. no ongoing segment merges) by specifying additional retry properties.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Mar 3, 2020
| return return_value | ||
| else: | ||
| self.logger.debug("%s has returned with an error: %s.", repr(self.delegate), return_value) |
There was a problem hiding this comment.
I am wondering if it'd be handy to log this more eagerly than only on debug, for troubleshooting purposes and giving a more complete picture of what's going on without having to switch to debug.
Do you think it'd become very chatty?
There was a problem hiding this comment.
IMHO it could indeed become a bit chatty because it would add a log entry every time the condition is not yet met.
|
Thanks for your review! :) |
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 3, 2020
With this commit we change all tracks to increase the request timeout of the `force-merge` task to ensure the force merge finishes before we move on. We also include another task that waits until all ongoing segment merges finish. Older Rally versions will entirely rely on the increased request timeout for force merges but newer Rally versions (every version including elastic/rally#925) will evaluate the condition and wait accordingly until the system is quiet. Relates elastic/rally#925
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 3, 2020
With this commit we change all tracks to increase the request timeout of the `force-merge` task to ensure the force merge finishes before we move on. We also include another task that waits until all ongoing segment merges finish. Older Rally versions will entirely rely on the increased request timeout for force merges but newer Rally versions (every version including elastic/rally#925) will evaluate the condition and wait accordingly until the system is quiet. Relates elastic/rally#925
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 3, 2020
With this commit we change all tracks to increase the request timeout of the `force-merge` task to ensure the force merge finishes before we move on. We also include another task that waits until all ongoing segment merges finish. Older Rally versions will entirely rely on the increased request timeout for force merges but newer Rally versions (every version including elastic/rally#925) will evaluate the condition and wait accordingly until the system is quiet. Relates elastic/rally#925
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 3, 2020
With this commit we change all tracks to increase the request timeout of the `force-merge` task to ensure the force merge finishes before we move on. We also include another task that waits until all ongoing segment merges finish. Older Rally versions will entirely rely on the increased request timeout for force merges but newer Rally versions (every version including elastic/rally#925) will evaluate the condition and wait accordingly until the system is quiet. Relates elastic/rally#925
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 3, 2020
With this commit we change all tracks to increase the request timeout of the `force-merge` task to ensure the force merge finishes before we move on. We also include another task that waits until all ongoing segment merges finish. Older Rally versions will entirely rely on the increased request timeout for force merges but newer Rally versions (every version including elastic/rally#925) will evaluate the condition and wait accordingly until the system is quiet. Relates elastic/rally#925
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 3, 2020
With this commit we change all tracks to increase the request timeout of the `force-merge` task to ensure the force merge finishes before we move on. We also include another task that waits until all ongoing segment merges finish. Older Rally versions will entirely rely on the increased request timeout for force merges but newer Rally versions (every version including elastic/rally#925) will evaluate the condition and wait accordingly until the system is quiet. Relates elastic/rally#925
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 3, 2020
With this commit we change all tracks to increase the request timeout of the `force-merge` task to ensure the force merge finishes before we move on. We also include another task that waits until all ongoing segment merges finish. Older Rally versions will entirely rely on the increased request timeout for force merges but newer Rally versions (every version including elastic/rally#925) will evaluate the condition and wait accordingly until the system is quiet. Relates elastic/rally#925
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
Mar 4, 2020
With this commit we make the index-stats operation more lenient so it can check conditions for paths that don't (yet) exist. One use case for this is to wait until a certain index shows up in the stats. Relates elastic#925
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 5, 2020
With this commit we make the index-stats operation more lenient so it can check conditions for paths that don't (yet) exist. One use case for this is to wait until a certain index shows up in the stats. Relates #925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we expand the existing
indices-statsoperation andallow to pass a condition based on a path and an expected value. This
has a variety of use cases:
number of documents
by specifying additional retry properties.