Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't invoke setup.py directly #928

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Mar 4, 2020

Installation should always be done via pip (which is available as a
builtin Python module since 3.3) and not by calling setup.py
directly.

Also avoid conflicts with system pip packages by using the pip module
from Python.

Installation should always be done via pip (which is available as a
builtin Python module since 3.3) and not by calling setup.py
directly.

Also avoid conflicts with system pip packages by using the pip module
from Python.
@dliappis dliappis added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Mar 4, 2020
@dliappis dliappis added this to the 1.5.0 milestone Mar 4, 2020
@dliappis dliappis self-assigned this Mar 4, 2020
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this!

@dliappis dliappis merged commit 265bf62 into elastic:master Mar 4, 2020
@dliappis dliappis deleted the dont-use-setuppy-directly branch March 4, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants