Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Rally revision in metrics metadata #931

Merged

Conversation

danielmitterdorfer
Copy link
Member

Rally already stores the version string as metrics metadata. However,
for unreleased versions we intermingle the version string with the git
revision making it hard to determine the revision automatically.

With this commit we store the git revision of Rally separately from the
version for race and results metadata. This allows users to derive
Rally's git revision more easily.

Rally already stores the version string as metrics metadata. However,
for unreleased versions we intermingle the version string with the git
revision making it hard to determine the revision automatically.

With this commit we store the git revision of Rally separately from the
version for race and results metadata. This allows users to derive
Rally's git revision more easily.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated labels Mar 6, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Mar 6, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 6, 2020
Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit 29bbe15 into elastic:master Mar 10, 2020
@danielmitterdorfer danielmitterdorfer deleted the rally-rev-metrics branch March 10, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants