Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache source artifacts by default #998

Merged
merged 1 commit into from
May 25, 2020
Merged

Cache source artifacts by default #998

merged 1 commit into from
May 25, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add the artifact cache introduced by #992 also for
plugins and implement a cache cleanup mechanism that cleans up artifacts
after seven days by default (can be configured with cache.days). As
artifact caching can now replace the pipeline from-sources-skip-build
we deprecate it along with from-sources-complete and introduce a new
pipeline from-sources instead.

@danielmitterdorfer
Cache source artifacts by default
5924012 
With this commit we add the artifact cache introduced by elastic#992 also for
plugins and implement a cache cleanup mechanism that cleans up artifacts
after seven days by default (can be configured with `cache.days`). As
artifact caching can now replace the pipeline `from-sources-skip-build`
we deprecate it along with `from-sources-complete` and introduce a new
pipeline `from-sources` instead.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels May 20, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.1 milestone May 20, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this May 20, 2020
ebadyano
ebadyano approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank. you!

dliappis
dliappis approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@danielmitterdorfer danielmitterdorfer merged commit 78a5fb5 into elastic:master May 25, 2020
@danielmitterdorfer danielmitterdorfer deleted the enable-src-artifact-cache branch May 25, 2020 07:45
@danielmitterdorfer
Copy link
Member Author

Thanks for the reviews! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadyano ebadyano ebadyano approved these changes

@dliappis dliappis dliappis approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@danielmitterdorfer @dliappis @ebadyano