Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add named 'Hook' export #64

Merged
merged 2 commits into from
Apr 12, 2023
Merged

feat: add named 'Hook' export #64

merged 2 commits into from
Apr 12, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Apr 12, 2023

Also prefer this form. This is because it is, apparently, easier to
type for and use named exports with TypeScript and ESM, rather than
"default exports".

Refs: open-telemetry/opentelemetry-js#3701

Also *prefer* this form. This is because it is, apparently, easier to
type for and use named exports with TypeScript and ESM, rather than
"default exports".

Refs: open-telemetry/opentelemetry-js#3701
@trentm trentm self-assigned this Apr 12, 2023
@trentm
Copy link
Member Author

trentm commented Apr 12, 2023

The assumption is that this will resolve open-telemetry/opentelemetry-js#3701 -- though I wasn't able to reproduce the exact case.

@trentm trentm merged commit 730dea9 into main Apr 12, 2023
@trentm trentm deleted the trentm/export-Hook-prop branch April 12, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant