[a11y] More accessible MultiCheckboxFacets #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to fix a merge conflict with #311! |
JasonStoltz
approved these changes
Jul 9, 2019
yakhinvadim
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick semantic markup change which enhances many screen readers' ability to associate multiple checkbox groups with its parent group label.
Before
After
Notice how California now reads out the parent "States" label, giving more context to keyboard tabbing users.
Screencap
^ Posting for general edification - note how the parent
legendis only read out when the user tabs into the first input within thefieldsetgroup, and is not read out again when tabbing to other items within the group. This is great behavior for context while not becoming repetitive.List of changes
divs tofieldset/legendtags.QA