Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds note about DaemonSet support #5675
Adds note about DaemonSet support #5675
Changes from 1 commit
76799fa
610facb
5018047
5f2e038
e57083b
09ab0dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this -- so was this removal of support backported to 8.10? Typically I'd expect the previous versions to support something, and then in the current version we stop supporting it.
But if we're removing support even from previous versions, then we'd need to update ALL the release notes files for all the versions that we no longer support (so make the same change to 8.11.asciidoc, 8.12.asciidoc, etc.). And then update all of those files in each one of the version branches affected. This will probably goof up Mergify at some point, since it's not really set up for complex stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of support was in 8.10, but wasn't documented at the time. That's why I think it makes sense to just add it to the 8.10 RNs. Nothing about this feature changed in the 8.11 etc. versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, makes sense. Thanks!