Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds note about DaemonSet support #5675

Merged
merged 6 commits into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/getting-started/install-endpoint.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Like other Elastic integrations, {elastic-defend} is integrated into the {agent}

If you're using macOS, some versions may require you to grant Full Disk Access to different kernels, system extensions, or files. Refer to <<elastic-endpoint-deploy-reqs, requirements for {elastic-endpoint}>> if you're installing the {elastic-endpoint} or <<endgame-sensor-full-disk-access, requirements for the Endgame sensor>> for more information.

NOTE: Elastic Defend is not supported for deployment as a DaemonSet in Kubernetes.
benironside marked this conversation as resolved.
Show resolved Hide resolved

[discrete]
[[add-security-integration]]
== Add the {elastic-defend} integration
Expand Down
2 changes: 1 addition & 1 deletion docs/release-notes/8.10.asciidoc
benironside marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ There are no user-facing changes in 8.10.2.
[discrete]
[[breaking-changes-8.10.0]]
==== Breaking changes
There are no breaking changes in 8.10.0.
* Deploying Elastic Defend as a DaemonSet in Kubernetes is no longer supported.
benironside marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this -- so was this removal of support backported to 8.10? Typically I'd expect the previous versions to support something, and then in the current version we stop supporting it.

But if we're removing support even from previous versions, then we'd need to update ALL the release notes files for all the versions that we no longer support (so make the same change to 8.11.asciidoc, 8.12.asciidoc, etc.). And then update all of those files in each one of the version branches affected. This will probably goof up Mergify at some point, since it's not really set up for complex stuff.

Copy link
Contributor Author

@benironside benironside Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of support was in 8.10, but wasn't documented at the time. That's why I think it makes sense to just add it to the 8.10 RNs. Nothing about this feature changed in the 8.11 etc. versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, makes sense. Thanks!


[discrete]
[[features-8.10.0]]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ Like other Elastic integrations, ((elastic-defend)) is integrated into the ((age

If you're using macOS, some versions may require you to grant Full Disk Access to different kernels, system extensions, or files. Refer to <DocLink slug="/serverless/security/elastic-endpoint-deploy-reqs">requirements for ((elastic-endpoint))</DocLink> if you're installing the ((elastic-endpoint)) or <DocLink slug="/serverless/security/endgame-sensor-full-disk-access">requirements for the Endgame sensor</DocLink> for more information.

<DocCallOut title="Note">
Elastic Defend is not supported for deployment as a DaemonSet in Kubernetes.
benironside marked this conversation as resolved.
Show resolved Hide resolved
</DocCallOut>

<div id="add-security-integration"></div>

## Add the ((elastic-defend)) integration
Expand Down
Loading