Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless][8.16] Logs request during preview rule execution #5871

Merged
merged 25 commits into from
Oct 16, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Sep 30, 2024

@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release v8.16.0 labels Sep 30, 2024
@nastasha-solomon nastasha-solomon self-assigned this Sep 30, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Sep 30, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon marked this pull request as ready for review September 30, 2024 04:39
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner September 30, 2024 04:39
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
@nastasha-solomon
Copy link
Contributor Author

run docs-build rebuild

vitaliidm
vitaliidm previously approved these changes Oct 1, 2024
benironside
benironside previously approved these changes Oct 1, 2024
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought the use of the word "submit" was a bit surprising, I'm not sure I've seen it used that way, I would have expected "execute" instead, but I guess you might have been avoiding talking about "rule executions executing queries" and I think the meaning is clear.

docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/serverless/rules/rules-ui-create.mdx Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/serverless/rules/rules-ui-create.mdx Outdated Show resolved Hide resolved
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@nastasha-solomon nastasha-solomon requested a review from a team October 3, 2024 00:23
@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Oct 16, 2024

Verified that this feature appears in the UI on prod and works as intended.

@nastasha-solomon nastasha-solomon merged commit 61b4a66 into main Oct 16, 2024
4 checks passed
@nastasha-solomon nastasha-solomon deleted the issue-5844-logged-es-request-rule-preview branch October 16, 2024 15:06
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
* First draft

* Serverless first draft

* Update docs/detections/rules-ui-create.asciidoc

* Fixing typos

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* Vitalii's input

* Updated anchor text

* Updated title

* Minor changes

* Removed extra the

* Fix conflict

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>

* Update docs/detections/rules-ui-create.asciidoc

* Vitalii's feedback round 2

* var fixes

* Active voice

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/serverless/rules/rules-ui-create.mdx

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/serverless/rules/rules-ui-create.mdx

* Update docs/serverless/rules/rules-ui-create.mdx

* Update slug

* slugslugslug

---------

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 61b4a66)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.mdx
nastasha-solomon added a commit that referenced this pull request Oct 17, 2024
…backport #5871) (#5938)

* [Serverless][8.16] Logs request during preview rule execution (#5871)

* First draft

* Serverless first draft

* Update docs/detections/rules-ui-create.asciidoc

* Fixing typos

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* Vitalii's input

* Updated anchor text

* Updated title

* Minor changes

* Removed extra the

* Fix conflict

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>

* Update docs/detections/rules-ui-create.asciidoc

* Vitalii's feedback round 2

* var fixes

* Active voice

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/serverless/rules/rules-ui-create.mdx

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/serverless/rules/rules-ui-create.mdx

* Update docs/serverless/rules/rules-ui-create.mdx

* Update slug

* slugslugslug

---------

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 61b4a66)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Nov 7, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security Effort: Small Issues that can be resolved quickly Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] logs request during preview rule execution
5 participants