Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request][Serverless][8.16] GA-ing alert suppression for IM rule, Threshold rule, ML rule, ES|QL rule and New Terms rule #5926

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 15, 2024

Fixes #5897

ESS

Serverless

  • Suppress detection alerts: The note at the start of the page now shows that alert suppression is only in tech preview for the event correlation (EQL) rule type.
  • Create rule: Removed the tech preview label at the start of the step that describes how to configure alert suppression for indicator match, threshold, ML, ES|QL, and new term rule types.

@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release v8.16.0 labels Oct 15, 2024
@nastasha-solomon nastasha-solomon self-assigned this Oct 15, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Oct 15, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 15, 2024 18:37
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner October 15, 2024 18:37
Copy link
Contributor

mergify bot commented Oct 16, 2024

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-5897-alert-suppress-ga upstream/issue-5897-alert-suppress-ga
git merge upstream/main
git push upstream issue-5897-alert-suppress-ga

jmikell821
jmikell821 previously approved these changes Oct 16, 2024
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates!

@nastasha-solomon nastasha-solomon merged commit d154348 into main Oct 23, 2024
5 checks passed
@nastasha-solomon nastasha-solomon deleted the issue-5897-alert-suppress-ga branch October 23, 2024 02:25
mergify bot pushed a commit that referenced this pull request Oct 23, 2024
…eshold rule, ML rule, ES|QL rule and New Terms rule (#5926)

* Updates label

* Updates create rule docs

* Fixed note

(cherry picked from commit d154348)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.mdx
#	docs/serverless/rules/rules-ui-create.mdx
mergify bot pushed a commit that referenced this pull request Oct 23, 2024
…eshold rule, ML rule, ES|QL rule and New Terms rule (#5926)

* Updates label

* Updates create rule docs

* Fixed note

(cherry picked from commit d154348)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.mdx
#	docs/serverless/rules/rules-ui-create.mdx
nastasha-solomon added a commit that referenced this pull request Oct 23, 2024
…e, Threshold rule, ML rule, ES|QL rule and New Terms rule (backport #5926) (#5970)

* [Request][Serverless][8.16] GA-ing alert suppression for IM rule, Threshold rule, ML rule, ES|QL rule and New Terms rule (#5926)

* Updates label

* Updates create rule docs

* Fixed note

(cherry picked from commit d154348)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.mdx
#	docs/serverless/rules/rules-ui-create.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Oct 23, 2024
…le, Threshold rule, ML rule, ES|QL rule and New Terms rule (backport #5926) (#5971)

* [Request][Serverless][8.16] GA-ing alert suppression for IM rule, Threshold rule, ML rule, ES|QL rule and New Terms rule (#5926)

* Updates label

* Updates create rule docs

* Fixed note

(cherry picked from commit d154348)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.mdx
#	docs/serverless/rules/rules-ui-create.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Nov 7, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security Effort: Small Issues that can be resolved quickly Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.16.0 v8.17.0
Projects
None yet
4 participants