Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset criticality advanced setting removed #5991

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Oct 24, 2024

Resolves #5975. Removes all references to the asset criticality advanced setting. The setting has been removed and asset criticality is now available by default.

Previews

ESS:

Serverless:

Open the link in this comment, navigate to Security -> View serverless docs, and then to the following pages:

  • Manage settings -> Advanced settings
  • Explore your data -> Host page
  • Explore your data -> Users page
  • Advanced Entity Analytics -> Entity risk scoring
  • Advanced Entity Analytics -> Entity risk scoring -> Entity risk scoring requirements
  • Advanced Entity Analytics -> Entity risk scoring -> Asset criticality

@natasha-moore-elastic natasha-moore-elastic added Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release Team: Entity Analytics v8.16.0 v8.17.0 labels Oct 24, 2024
@natasha-moore-elastic natasha-moore-elastic self-assigned this Oct 24, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review October 24, 2024 16:13
@natasha-moore-elastic natasha-moore-elastic requested a review from a team as a code owner October 24, 2024 16:13
Copy link

@CAWilson94 CAWilson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus my minor confusion (in the comments)

* Turn on the `securitySolution:enableAssetCriticality` <<enable-asset-criticality, advanced setting>>.

For more information, refer to <<ers-requirements, Entity risk scoring prerequisites>>.
To view and assign asset criticality, you must have the appropriate user role. For more information, refer to <<ers-requirements, Entity risk scoring prerequisites>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit confused here because I thought the PR I just reviewed said Asset Criticality was being renamed to Entity Store?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Asset Criticality page is now called Entity Store, but asset criticality as a feature still exists, it's just now managed through the Entity Store page.

@@ -41,8 +41,6 @@ To turn on the risk scoring engine, you need either the appropriate <DocLink slu

## Asset criticality
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused because in the preview this says Entity Risk Scoring but here it says Asset Criticality. Not a problem I guess since the preview looks good? Maybe I'm confused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should have linked to the exact section – https://security-docs_bk_5991.docs-preview.app.elstc.co/guide/en/security/master/ers-requirements.html#_asset_criticality. I'll edit the link in the description.

@natasha-moore-elastic natasha-moore-elastic merged commit 2390859 into main Oct 30, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
(cherry picked from commit 2390859)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
#	docs/serverless/advanced-entity-analytics/asset-criticality.mdx
#	docs/serverless/advanced-entity-analytics/entity-risk-scoring.mdx
#	docs/serverless/advanced-entity-analytics/ers-req.mdx
#	docs/serverless/explore/hosts-overview.mdx
#	docs/serverless/explore/users-page.mdx
#	docs/serverless/settings/advanced-settings.mdx
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
(cherry picked from commit 2390859)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
#	docs/serverless/advanced-entity-analytics/asset-criticality.mdx
#	docs/serverless/advanced-entity-analytics/entity-risk-scoring.mdx
#	docs/serverless/advanced-entity-analytics/ers-req.mdx
#	docs/serverless/explore/hosts-overview.mdx
#	docs/serverless/explore/users-page.mdx
#	docs/serverless/settings/advanced-settings.mdx
natasha-moore-elastic added a commit that referenced this pull request Oct 30, 2024
…6034)

* Asset criticality advanced setting removed (#5991)

(cherry picked from commit 2390859)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
#	docs/serverless/advanced-entity-analytics/asset-criticality.mdx
#	docs/serverless/advanced-entity-analytics/entity-risk-scoring.mdx
#	docs/serverless/advanced-entity-analytics/ers-req.mdx
#	docs/serverless/explore/hosts-overview.mdx
#	docs/serverless/explore/users-page.mdx
#	docs/serverless/settings/advanced-settings.mdx

* Delete docs/serverless directory and its contents

* Update docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Oct 30, 2024
)

* Asset criticality advanced setting removed (#5991)

(cherry picked from commit 2390859)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
#	docs/serverless/advanced-entity-analytics/asset-criticality.mdx
#	docs/serverless/advanced-entity-analytics/entity-risk-scoring.mdx
#	docs/serverless/advanced-entity-analytics/ers-req.mdx
#	docs/serverless/explore/hosts-overview.mdx
#	docs/serverless/explore/users-page.mdx
#	docs/serverless/settings/advanced-settings.mdx

* Delete docs/serverless directory and its contents

* Update docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@natasha-moore-elastic natasha-moore-elastic mentioned this pull request Nov 5, 2024
24 tasks
acorretti pushed a commit that referenced this pull request Nov 19, 2024
(cherry picked from commit 2390859)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
#	docs/serverless/advanced-entity-analytics/asset-criticality.mdx
#	docs/serverless/advanced-entity-analytics/entity-risk-scoring.mdx
#	docs/serverless/advanced-entity-analytics/ers-req.mdx
#	docs/serverless/explore/hosts-overview.mdx
#	docs/serverless/explore/users-page.mdx
#	docs/serverless/settings/advanced-settings.mdx
acorretti pushed a commit that referenced this pull request Nov 19, 2024
(cherry picked from commit 2390859)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
#	docs/serverless/advanced-entity-analytics/asset-criticality.mdx
#	docs/serverless/advanced-entity-analytics/entity-risk-scoring.mdx
#	docs/serverless/advanced-entity-analytics/ers-req.mdx
#	docs/serverless/explore/hosts-overview.mdx
#	docs/serverless/explore/users-page.mdx
#	docs/serverless/settings/advanced-settings.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security Effort: Small Issues that can be resolved quickly Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Entity Analytics v8.16.0 v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Asset Criticality Advanced Setting flag removal
4 participants