Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image reference bug #6094

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix image reference bug #6094

merged 1 commit into from
Nov 8, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Nov 8, 2024

Follow up fix for image reference bug introduced in #6051.

The bug doesn't manifest in the main branch, but will become a problem for future backport branches created off of main. I noticed this in the backport PRs #6051 and #6093 and fixed the errors in those PRs, but then realized that the problem might re-emerge again any time another backport branch gets created.

The problem is that the images/icons subdirectory won't exist for those ESS-only backport branches, because the location only exists in serverless docs.

@joepeeples joepeeples added bug Something isn't working backport-skip labels Nov 8, 2024
@joepeeples joepeeples self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@joepeeples joepeeples marked this pull request as ready for review November 8, 2024 22:56
@joepeeples joepeeples requested a review from a team as a code owner November 8, 2024 22:56
@joepeeples joepeeples enabled auto-merge (squash) November 8, 2024 22:59
@joepeeples joepeeples enabled auto-merge (squash) November 8, 2024 23:01
@joepeeples joepeeples merged commit e3fae86 into main Nov 8, 2024
4 checks passed
@joepeeples joepeeples deleted the fix-icon-bug branch November 8, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants