Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow subcommand to receive common options #572

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: allow subcommand to receive common options #572

merged 1 commit into from
Aug 10, 2022

Conversation

vigneshshanmugam
Copy link
Member

@apmmachine
Copy link

apmmachine commented Aug 3, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-03T21:04:19.868+0000

  • Duration: 14 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 179
Skipped 2
Total 181

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

andrewvc
andrewvc approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much nicer! Confirmed on the CLI

@andrewvc andrewvc merged commit 25c1430 into elastic:main Aug 10, 2022
@vigneshshanmugam vigneshshanmugam deleted the pass-params branch August 10, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--params option should be listed under push subcommand
3 participants
@vigneshshanmugam @apmmachine @andrewvc