-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support streaming mode for push command #576
Merged
vigneshshanmugam
merged 8 commits into
elastic:main
from
justinkambic:push-with-streams
Aug 17, 2022
Merged
feat: support streaming mode for push command #576
vigneshshanmugam
merged 8 commits into
elastic:main
from
justinkambic:push-with-streams
Aug 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
force-pushed
the
push-with-streams
branch
from
August 11, 2022 15:10
9aefbb3
to
780d0d1
Compare
vigneshshanmugam
force-pushed
the
push-with-streams
branch
from
August 11, 2022 23:31
56b50b3
to
0d90ade
Compare
vigneshshanmugam
force-pushed
the
push-with-streams
branch
from
August 11, 2022 23:32
0d90ade
to
9119f0c
Compare
vigneshshanmugam
changed the title
Update
feat: support streaming mode for push command
Aug 11, 2022
push
to work with streams…s-1 into push-with-streams
justinkambic
commented
Aug 12, 2022
justinkambic
force-pushed
the
push-with-streams
branch
from
August 17, 2022 15:35
1602f62
to
098f73c
Compare
dominiqueclarke
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me!
Tested in 8.4.0 Kibana with streams, as well as in 8.3.0 Kibana without streams.
Tested creation, updates, and deletion.
Tested individual monitor errors (via failedMonitors), and the formatting for that is also working well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #575.
This patch will make it possible for the Synthetics Agent to
push
monitors to Kibana via a streams endpoint.Testing this PR
Configure Kibana
Firstly, build and run the Kibana streaming PR. It is ok if it runs against a fresh local Elasticsearch cluster.
Once Kibana is running, log in as a user who can write (I simply used the
elastic
user), and create an API key, which we will supply to Synthetics forpush
ing.Lastly, go to the Uptime application and enable monitor management. You should be prompted to create an Agent policy. Do this, following default options. Once your agent policy is created, the baseline configuration for Kibana is ready.
Configure Synthetics Project
npm run build
,npm link
mkdir beep
,node dist/cli init beep
, follow the promptcd beep
,npm link @elastic/synthetics
env SYNTHETICS_API_KEY={API_KEY} npm run push
Expected output