fix: use correct loader for journey files #626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix [Project monitors] Push command unable to parse TypeScript #625
When journey files are pushed, We treat these files differently when bundling
When the journey files are loaded by the bundler, the underlying loader in the
ES build
was defaulting toJS
which throws error whenTypescript types
are used inside the journey files. This PR fixes the problem by using appropriate loader for the journey files whenpush
command is invoked. The test is also added to ensure this does not break in the future.Testing
npm run build
example.journey.ts
SYNTHETICS_API_KEY="" npm run push