fix: properly handle non error exceptions

[andrewvc]

Catch non Error objects that are thrown as exceptions. As a quick workaround devs sometimes throw using syntax like throw("foo") instead of the more correct throw(new Error("foo")).

The current code will swallow those errors.

Fixes #692

Testing

This PR includes a simple unit test. Given that the impact of #692 is low, and writing a true E2E test demonstrating the resolution of that issue, I think manual testing of that scenario is fine.

To do so, save the following file as bad.ts

//bad.ts

step("instant exception", () => {
  throw("simple exception");
})

Then, run

npm run build && node dist/cli.js --inline --rich-events < bad.ts | grep journey/end |  jq .error`

after checking out this branch. You should see this error. Switching back to main the error should be missing.

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-01-17T14:48:34.619+0000

• Duration: 16 min 33 sec

Test stats 🧪

Test	Results
Failed	0
Passed	211
Skipped	2
Total	213

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[vigneshshanmugam]

LGTM