Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for APM service.name in Heartbeat/Uptime #220

Closed
andrewvc opened this issue Jun 4, 2020 · 6 comments · Fixed by elastic/kibana#73618
Closed

Support for APM service.name in Heartbeat/Uptime #220

andrewvc opened this issue Jun 4, 2020 · 6 comments · Fixed by elastic/kibana#73618
Assignees
Labels
discuss enhancement New feature or request test-plan-ok Indicates an issue has been tested for release v7.10.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Jun 4, 2020

Today, linking between Uptime / APM is done only via URL. It would be trivial to add a common option to heartbeat monitor options service_name, that added the appropriate field for APM. This could then be used by the integrations links on the monitor overview/detail page to cross-link to APM.

@andrewvc andrewvc added enhancement New feature or request discuss labels Jun 4, 2020
@drewpost
Copy link

drewpost commented Jun 8, 2020

Trivial effort and high return - I am in favour of prioritising this. Can we elaborate a bit more with some user stories to really bring home the value of it @andrewvc and then discuss with the team when to bring it in?

@andrewvc
Copy link
Contributor Author

andrewvc commented Jun 9, 2020

As a user of both APM and Uptime, I'd like to more easily navigate between the two apps. Being able to jump from an uptime outage to an APM analysis of the same outage is something I expect. I'd like to be able to view a discrete error, then easily view that time segment in the relevant service in APM.

@tbragin
Copy link

tbragin commented Jun 16, 2020

+1 on this effort. Aligning and using most important ECS fields across our apps is so important.

cc @elastic/observability-pm @roncohen @alvarolobato

@cyrille-leclerc
Copy link

+1 on this initiative.

@andrewvc minor comment: I think that the ECS field name is service.name rather than service_name (see Elastic Common Schema (ECS) / Service Fields).

The next integration between APM and Uptime my wishlist is the usage of transaction.id and trace.id in uptime 👼

@andrewvc
Copy link
Contributor Author

@cyrille-leclerc great ideas for transaction stuff in future versions! Heartbeat PR is here: elastic/beats#19932

@katrin-freihofner any input on this? Adding the menu item to the integrations list should be very straightforward to the uptime UI.

@katrin-freihofner
Copy link
Contributor

I think this a great initiative. Linking to the service from the integrations menu should work. I think this could even work better with the new integrations menu. A shared component for this is already available.

andrewvc added a commit to elastic/beats that referenced this issue Jul 17, 2020
Adds a new standard service_name option to the heartbeat config file. While possible with fields already, adding this as a first class option encourages use of this important field for integration.

First step toward elastic/uptime#220

This PR also refactors some internal bits where we were passing too many parameters already, and adding service_name would just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code.
andrewvc added a commit to andrewvc/beats that referenced this issue Jul 17, 2020
Adds a new standard service_name option to the heartbeat config file. While possible with fields already, adding this as a first class option encourages use of this important field for integration.

First step toward elastic/uptime#220

This PR also refactors some internal bits where we were passing too many parameters already, and adding service_name would just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code.

(cherry picked from commit 6197850)
andrewvc added a commit to elastic/beats that referenced this issue Jul 29, 2020
)

Adds a new standard service_name option to the heartbeat config file. While possible with fields already, adding this as a first class option encourages use of this important field for integration.

First step toward elastic/uptime#220

This PR also refactors some internal bits where we were passing too many parameters already, and adding service_name would just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code.

(cherry picked from commit 6197850)
andrewvc added a commit to andrewvc/kibana that referenced this issue Jul 29, 2020
With elastic/beats#19932 coming in 7.10 adding
the `service.name` ECS field is very easy. We should prefer this field
when cross linking to APM, hence this PR.

Resolves elastic/uptime#220
@shahzad31 shahzad31 assigned shahzad31 and andrewvc and unassigned shahzad31 Jul 29, 2020
andrewvc added a commit to elastic/kibana that referenced this issue Jul 29, 2020
#73618)

With elastic/beats#19932 coming in 7.10 adding
the `service.name` ECS field is very easy. We should prefer this field
when cross linking to APM, hence this PR.

Resolves elastic/uptime#220
andrewvc added a commit to andrewvc/kibana that referenced this issue Jul 29, 2020
elastic#73618)

With elastic/beats#19932 coming in 7.10 adding
the `service.name` ECS field is very easy. We should prefer this field
when cross linking to APM, hence this PR.

Resolves elastic/uptime#220
# Conflicts:
#	x-pack/plugins/uptime/public/lib/helper/observability_integration/get_apm_href.ts
andrewvc added a commit to elastic/kibana that referenced this issue Aug 5, 2020
#73618) (#73666)

With elastic/beats#19932 coming in 7.10 adding
the `service.name` ECS field is very easy. We should prefer this field
when cross linking to APM, hence this PR.

Resolves elastic/uptime#220
# Conflicts:
#	x-pack/plugins/uptime/public/lib/helper/observability_integration/get_apm_href.ts
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this issue Oct 14, 2020
Adds a new standard service_name option to the heartbeat config file. While possible with fields already, adding this as a first class option encourages use of this important field for integration.

First step toward elastic/uptime#220

This PR also refactors some internal bits where we were passing too many parameters already, and adding service_name would just be too much. We now pass a single larger struct for common monitor options which cleans up a lot of the code.
@justinkambic justinkambic added the test-plan-ok Indicates an issue has been tested for release label Oct 15, 2020
@zube zube bot removed the [zube]: Done label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New feature or request test-plan-ok Indicates an issue has been tested for release v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants