Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elastio terraform deployment automation example #100

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

Veetaha
Copy link
Contributor

@Veetaha Veetaha commented Aug 7, 2024

@Veetaha Veetaha force-pushed the feat/elastio-terraform-deployment branch from fb5bcb0 to c46f605 Compare August 7, 2024 18:19
@Veetaha Veetaha requested a review from anelson August 7, 2024 18:28
Copy link
Contributor

@anelson anelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

template_url = join(
"/",
[
"https://elastio-prod-artifacts-us-east-2.s3.us-east-2.amazonaws.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be any issue w/ deployments to some other region using the us-east-2 bucket, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the Cloudformation template URL can be in any region

elastio-terraform-deployment/module/variables.tf Outdated Show resolved Hide resolved
Veetaha and others added 2 commits August 7, 2024 22:32
Co-authored-by: Adam Nelson <anelson@users.noreply.github.com>
@Veetaha Veetaha merged commit d432943 into master Aug 7, 2024
5 checks passed
@Veetaha Veetaha deleted the feat/elastio-terraform-deployment branch August 7, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants