HTTP in cascadeproxy example returns Proxy Authentication Required

[gbraad]

When setting

goproxy/examples/cascadeproxy/main.go

Line 85 in 947c36d

request, err := http.NewRequest("GET", "https://ip.cn", nil)

as

-	request, err := http.NewRequest("GET", "https://ip.cn", nil)
+	request, err := http.NewRequest("GET", "http://ip.cn", nil)

execution results in

$ ./main
2018/08/10 05:37:35 serving end proxy server at localhost:8082
2018/08/10 05:37:35 serving middle proxy server at localhost:8081
2018/08/10 05:37:36 [001] INFO: Got request / ip.cn GET http://ip.cn/
2018/08/10 05:37:36 [001] INFO: Sending request GET http://ip.cn/
2018/08/10 05:37:36 [001] INFO: Got request / ip.cn GET http://ip.cn/
2018/08/10 05:37:36 [001] INFO: Copying response to client  [407]
2018/08/10 05:37:36 [001] INFO: Copied 33 bytes to client error=<nil>
2018/08/10 05:37:36 [001] INFO: Received response 407 Proxy Authentication Required
2018/08/10 05:37:36 [001] INFO: Copying response to client 407 Proxy Authentication Required [407]
2018/08/10 05:37:36 [001] INFO: Copied 33 bytes to client error=<nil>
2018/08/10 05:37:36 status 407, data 407 Proxy Authentication Required

While the headers are set in middleproxy using:

goproxy/examples/cascadeproxy/main.go

Lines 74 to 77 in 947c36d

	middleProxy.OnRequest().Do(goproxy.FuncReqHandler(func(req *http.Request, ctx *goproxy.ProxyCtx) (*http.Request, *http.Response) {
	SetBasicAuth(username, password, req)
	return req, nil
	}))

goproxy/examples/cascadeproxy/main.go

Lines 22 to 24 in 947c36d

	func SetBasicAuth(username, password string, req *http.Request) {
	req.Header.Set(ProxyAuthHeader, fmt.Sprintf("Basic %s", basicAuth(username, password)))
	}

they do not seem to arrive at the endproxy.

[gbraad]

@liudanking WDYT?

[liudanking]

I will check it asap 获取 Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ 收件人: Gerard Braad <notifications@github.com> 发送时间: 星期五, 八月 10, 2018 13:45 收件人: elazarl/goproxy 抄送: Danieliu; Mention 主题: Re: [elazarl/goproxy] HTTP in cascadeproxy example returns Proxy Authentication Required (#306) @liudanking<https://github.com/liudanking> WDYT? ― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#306 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACi2OI1E4S7LRa04gAuM031v6zt71DJtks5uPR3rgaJpZM4V3nz2>.

[liudanking]

Hi @gbraad, the reason is that the middle proxy removes the auth header:

https://github.com/elazarl/goproxy/blob/master/proxy.go#L88

add @elazarl

[gbraad]

This should be configurable, as it is not always wanted to remove headers... especially in this case it should be passed on.

Note: this was changed as part of #78

---

As of Proxy-* headers, seems like a good idea to remove those, will do in a few days.

Maybe not... :-s Can this be made configurable... ?

[azak-azkaran]

This is still not fixed and could be fixed with @gbraad proposed changes.