Add KeepAcceptEncoding option, prevents proxy from changing Accept-Encoding sent by clients #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I now wonder why I added accept encoding, and not just send client's accept encoding. In retrospect it looks like a mistake. What does squid do? |
oec
added a commit
to oec/goproxy
that referenced
this pull request
Jul 4, 2019
|
This feature has been integrated in #585. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a new flag to the proxy,
KeepAcceptEncoding. When disabled, proxy behaviour remains the same to avoid breaking existing clients.The default behaviour is that the Accept-Encoding header on client requests is removed. The proxy outbound transport will then add an "Accept-Encoding: gzip" header to outbound requests.
With
KeepAcceptEncodingenabled the proxy will pass the header through. Note that if you want the proxy to never modify Accept-Encoding, you should also setDisableCompressiontrue on the proxy outbound transport (otherwise it will ask for gzip when the client does not send the header).Fixes #102 for me.