Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: more general support for half-closable connections #369

Merged
merged 1 commit into from
Feb 20, 2020
Merged

improvement: more general support for half-closable connections #369

merged 1 commit into from
Feb 20, 2020

Conversation

onokonem
Copy link
Contributor

No description provided.

elazarl
elazarl reviewed Feb 20, 2020
View reviewed changes
Copy link
Owner

@elazarl elazarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, but I wonder, what is the usecase?

https.go Show resolved Hide resolved
@onokonem
Copy link
Contributor Author

Looks nice, but I wonder, what is the usecase?

actually, 2 cases (and I run into both in our project)

  1. Not only net.TCPConn is half-closable, but also the net.UnixConn
  2. sometimes we have to wrap net.TCPConn with some custom type (we are reporting traffic, for example)

@elazarl elazarl merged commit 29f9e0b into elazarl:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elazarl elazarl elazarl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onokonem @elazarl