Don't return http 200 for ConnectHijack actions #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending HTTP 200 back to the client connection before invoking the todo.Hijack() method for a ConnectHijack action makes it impossible to cascade the http 502 back to the client in case we wanted to abort prematurely (e.g.the target address is unavailable) [RFC 2817](https://tools.ietf.org/html/rfc2817#section-5.3) States: ``` 5.3 Establishing a Tunnel with CONNECT Any successful (2xx) response to a CONNECT request indicates that the proxy has established a connection to the requested host and port, and has switched to tunneling the current connection to that server connection. ``` It should be therefore up to the Hijack() method implementer to send the http 200 upon confirming that we can establish a tunnel.
|
I would like to second this PR, we had to maintain a local fork so we can hijack 200 messages on CONNECTs. Thanks for raising this @riraccuia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#376
Sending HTTP 200 to the client connection before invoking the todo.Hijack() method for a ConnectHijack action makes it impossible to cascade the http 502 (or any other error) back to the client in case we wanted to abort prematurely (e.g. the target address is unavailable)
RFC 2817 States:
It should be therefore up to the Hijack() method implementer to send the http 200 upon confirming that we can establish a tunnel.