Case insensitive host comparison #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #561.
Since RFC4343 states that DNS host is case-insensitive by definition, we should do a case-insensitive comparison to perform actions on certain hosts, without let the user bypassing them by simply changing the case of a character.
The DNS will resolve both the uppercase and the lowercase host text to the same IP address.
Existing integration should never rely on the case of the host, so applying this change to the whole
Proxy server should never care about the case of the host, so directly modifying
DstHostIsfunction to do a case insenstiive compare is appropriate in this case.