Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: SetRealReg must be called asynchronously. #78

Conversation

dh377
Copy link
Contributor

@dh377 dh377 commented Apr 25, 2022

Squashed commit:

[53e479d] Threading safe?

[df2911b] Trying solution: executing SetRealReg breaking channel.

[3c93e34] When do login or inquiry realtime,
if there is any error, it will return an error to client.

Squashed commit:

[53e479d] Threading safe?

[df2911b] Trying solution: executing SetRealReg breaking channel.

[3c93e34] When do login or inquiry realtime,
if there is any error, it will return an error to client.
@dh377 dh377 changed the title SetRealReg must be called asynchronously. Bugfix: SetRealReg must be called asynchronously. Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #78 (1021b13) into master (e91948d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master     #78      +/-   ##
=========================================
- Coverage    6.28%   6.27%   -0.01%     
=========================================
  Files         204     204              
  Lines       12824   12841      +17     
=========================================
  Hits          806     806              
- Misses      12018   12035      +17     
Flag Coverage Δ
windows-latest-py3.8 6.27% <0.00%> (-0.01%) ⬇️
windows-latest-py3.9 6.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...us/grpc/event/KiwoomOpenApiPlusRealEventHandler.py 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@dh377
Copy link
Contributor Author

dh377 commented Apr 25, 2022

I found #14 issue in mid of running KiwoomOpenApiPlusBidirectionalRealEventHandler and I changed the SetRealReg calling method to asyncronously.

@elbakramer elbakramer merged commit ffc2f41 into elbakramer:master Apr 28, 2022
@dh377 dh377 deleted the bugfix/api_controls_must_be_called_asynchronously branch April 28, 2022 19:17
@dh377 dh377 restored the bugfix/api_controls_must_be_called_asynchronously branch April 28, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants