Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit null and undefined values from query string produced by QueryStringAddon #230

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

dankochetov
Copy link
Contributor

Fixes #229

@elbywan
Copy link
Owner

elbywan commented May 11, 2024

👍 Thanks for the PR! I'm fine with adding this as long as it does not break existing code.

Can you add an argument to the addon which would toggle the new behaviour while preserving the existing as the default?

elbywan added 2 commits June 1, 2024 13:06
preserves backwards compatibility
@elbywan elbywan merged commit 193d539 into elbywan:master Jun 1, 2024
9 checks passed
@coveralls
Copy link

Coverage Status

coverage: 87.322% (+0.2%) from 87.137%
when pulling 9ac03ab on dankochetov:master
into b299791 on elbywan:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryStringAddon converts undefined values into empty strings instead of omitting them
3 participants