-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not depend on entire Rails gem. #35
Conversation
… for rails v7 yet. removed unused actioncable references in test
The test failed, please check it. |
Sorry I have never used Travis before. I updated the Travis Gemfile.lock files now. How can I test this without pushing changes to the PR so that Travis runs? I am still getting an error: "Run Running the tests locally works btw. |
This gem use Appraisal to manage multiple rails version dependency. You need to use it to update all Gemfile. |
https://github.com/elct9620/rails-letsencrypt/blob/master/.travis.yml The Rails 7 support is added but not listed in |
Seems got some problem due to the bundler version still configured to |
The gem dependency has some problems. I think we can drop |
Thanks for the pointers. I am new to Appraisals and Travis. Not sure why it is giving me an error now though:
I did Is there any way to test this with Travis without pushing to the PR? Sorry these commits are a bit of a mess now. |
Ok this is odd. Seems like there is some gem caching issue perhaps? Is it possible to trigger the test again? |
I had re-run the test for you. Maybe we can remove Travis CI and migrate to GitHub Actions later. For the Gemfile lock issue, the appraisal gem should provide a way to help you update all |
So now the Rails 7 test works for Ruby 2.7 but not for Ruby 2.6. It is saying railties 7.0.3.1 doesn't exist which is not correct. I think this could be a Travis issue. |
I have no idea about it. But you can check for Rails 7 is support Ruby 2.6 or not first 🤔 |
Closing in favour for #38 as this was done in my master branch and it doesn't seem possible to update the PR. |
Fixes #34