Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace form field widgets with a class, not class instance #34

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

alexey-v-paramonov
Copy link
Contributor

No description provided.

@coloradocarlos
Copy link
Contributor

coloradocarlos commented Feb 21, 2018

@alexey-v-paramonov Can you bump up the version number to 0.14.1? Otherwise get this warning with pip on CircleCI (also local environment):

Collecting git+git://github.com/alexey-v-paramonov/formly@master (from -r requirements/base.txt (line 34))
  Cloning git://github.com/alexey-v-paramonov/formly (to master) to /tmp/pip-n3rHLT-build
  Requirement already satisfied (use --upgrade to upgrade): formly==0.14.0 from git+git://github.com/alexey-v-paramonov/formly@master in ./venv/lib/python2.7/site-packages (from -r requirements/base.txt (line 34))

@grahamu
Copy link
Contributor

grahamu commented Feb 21, 2018

FYI @coloradocarlos @alexey-v-paramonov I'm actively working on a new formly release in #33. I'll be sure to include this PR and let you know of the new published version on PyPi when I'm done. New release uses namespacing, revised URL names, and contains an expanded test suite.

@jacobwegner
Copy link
Contributor

Thanks for the fix and test, @alexey-v-paramonov.

Since the newest release will be BI, @grahamu and I have decided to pull this in to a bugfix release.

@jacobwegner jacobwegner merged commit 1b5f510 into eldarion:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants