Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the requirement for generated files #13

Open
elderfo opened this issue Mar 20, 2017 · 4 comments
Open

Remove the requirement for generated files #13

elderfo opened this issue Mar 20, 2017 · 4 comments

Comments

@elderfo
Copy link
Owner

elderfo commented Mar 20, 2017

See #10 for more discussion on this

@skovhus
Copy link

skovhus commented Mar 23, 2017

It would be great to abstract this away from the user. But it is possible to do it dynamically with React Native bundler similar to webpack require.context as mentioned here https://getstorybook.io/docs/react-storybook/basics/writing-stories ...

Related: storybook-eol/react-native-storybook#103

@elderfo
Copy link
Owner Author

elderfo commented Mar 24, 2017

@skovhus, do you have an example of how to configure webpack to do what is in the link? I originally tried that route and was unsuccessful, which is why I ended up writing this.

@skovhus
Copy link

skovhus commented Mar 24, 2017

RN is not using webpack as bundler, so you cannot do this... I see now that my comment above didn't include a question. That was my intention. ; )

"But is it possible..."

@hendrul
Copy link
Contributor

hendrul commented Mar 16, 2018

At least this tool should always generate the file (storyLoader.js) even when there are no stories... currently It doesn't do anything when no stories are found, and this makes storybook.js fail because there is no storyLoader.js.. and also fails if there were stories and then I remove them, storyLoader.js does not get updated and fails at loading the stories

michaelbayday pushed a commit to michaelbayday/react-native-storybook-loader that referenced this issue Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants