Skip to content

Commit

Permalink
Removing react dep
Browse files Browse the repository at this point in the history 
Removing react dep to fix issue where multiple react versions would
load.
  • Loading branch information
Andreas Eldh committed Jan 5, 2015
1 parent c8f058d commit 4fd5ed1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
"scripts": {
"test": "make test"
},
"dependencies": {
"react": "^0.12.0"
},
"devDependencies": {
"coffee-script": "^1.8.0",
"mocha": "^2.0.1",
Expand Down

7 comments on commit 4fd5ed1

@kalasjocke
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! How come you ran into this? I wonder if I should move this into the main repo.

@eldh
Copy link
Owner

@eldh eldh commented on 4fd5ed1 Jan 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalasjocke I don't know why it happens, haven't fully investigated it. But I'm guessing webpack fails to dedupe properly for some reason. It happens a lot, it seems. facebook/react#2402

@eldh
Copy link
Owner

@eldh eldh commented on 4fd5ed1 Jan 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have another look tomorrow to see if I can fix it in some more sustainable way.

@eldh
Copy link
Owner

@eldh eldh commented on 4fd5ed1 Jan 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say it started happening after a while. Worked well from the start.

@kalasjocke
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great! If you find a sustainable solution a pull request would be fantastic.

@eldh
Copy link
Owner

@eldh eldh commented on 4fd5ed1 Jan 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalasjocke It's coming up soonish!

@kalasjocke
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldh 👍 👍

Please sign in to comment.