Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to embedded-hal 1.0 #6

Merged
merged 8 commits into from
Nov 11, 2024
Merged

update to embedded-hal 1.0 #6

merged 8 commits into from
Nov 11, 2024

Conversation

LiamGallagher737
Copy link
Contributor

@LiamGallagher737 LiamGallagher737 commented Nov 6, 2024 •
edited
Loading

These changed worked for me to be able to use shared-bus for multiple I²C devices at once.

eldruin
eldruin reviewed Nov 11, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!
Could you also adapt the tests, add an entry to the changelog and change the MSRV?
Here is an example of this in case it is useful to you.

@LiamGallagher737
Copy link
Contributor Author

All passing now

eldruin
eldruin approved these changes Nov 11, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!

@eldruin eldruin merged commit 4ec01b5 into eldruin:master Nov 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiamGallagher737 @eldruin