Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a user is logged in before displaying log or seeing system information #421

Closed
wants to merge 1 commit into from

Conversation

Bramas
Copy link
Contributor

@Bramas Bramas commented Nov 4, 2015

This resolves #420

For the check plugin, I let any user see the warnings this can be changed maybe.

This is my first PR on github!!! I hope everything is ok.
I made it because I think the Lychee is awsome!!

…nformation\n This resolve electerious/Lychee#420
@electerious
Copy link
Owner

Thanks for the PR. I understand your point. The reason for keeping them public: It helps to debug when the installation or an update failed. It's not possible to login in those cases.

@Bramas
Copy link
Contributor Author

Bramas commented Nov 6, 2015

That's why I left the errors public.
The warning also are still public since they do not reveal local information.
However, I really think the log (and the system information) must be hidden.

@Bramas
Copy link
Contributor Author

Bramas commented Nov 15, 2015

Do you want me to change something for the PR?
I really think this should be fixed quickly since the log and the system information may contains some private information and are currently public for every Lychee websites.

I took care of leaving the errors and warnings public in the check plugin because they are here for debug (and they do not contains sensible informations)

@electerious
Copy link
Owner

Merged it manually into develop. Thanks a lot! It will be part of Lychee 3.0.9.

@electerious electerious mentioned this pull request Jan 10, 2016
electerious added a commit that referenced this pull request Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants