Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary builds should provide a stable tag #1921

Open
magnetised opened this issue Nov 4, 2024 · 2 comments
Open

Canary builds should provide a stable tag #1921

magnetised opened this issue Nov 4, 2024 · 2 comments

Comments

@magnetised
Copy link
Contributor

Currently we build a "canary" image electricsql/electric:canary off of main. Because the tag electricsql/electric:canary is not stable, if we ask someone to pull an image based off of main, we have no idea which actual build they end up with.

We should tag canary images as electricsql/electric:canary and electricsql/electric:canary-$COMMIT_SHA so that electricsql/electric:canary always points to the most up-to-date build, but the same build is also available under an immutable tag.

@robacourt
Copy link
Contributor

It's stable if you use the SHA (currently it's sha256:644c25271c09e663fed4439c5c68fbe8e57e5dcc0d67ea92df32a40cdb11b12a )

But currently there's no record of what version of main is what SHA, and github doesn't display a history of the SHAs.

@alco
Copy link
Member

alco commented Dec 20, 2024

The old Electric used to log its version when starting which also helped identify the commit that's being run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants