Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (sync service): support qualified schema and table names #1518

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

kevin-dp
Copy link
Contributor

This PR addresses #1449 as it adds support for qualified schema and table names. To this end, i modified validate_table to parse (quoted) schema and table names.

@kevin-dp kevin-dp force-pushed the kevin/parse-qualified-table-names branch from a0daff0 to 09d06e7 Compare August 14, 2024 07:21
@kevin-dp kevin-dp marked this pull request as ready for review August 14, 2024 07:26
@kevin-dp kevin-dp requested a review from alco August 14, 2024 07:28
Copy link
Contributor

@robacourt robacourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kevin-dp kevin-dp merged commit 11f564d into main Aug 15, 2024
20 checks passed
@kevin-dp kevin-dp deleted the kevin/parse-qualified-table-names branch August 15, 2024 06:34
KyleAMathews pushed a commit that referenced this pull request Nov 1, 2024
This PR addresses #1449
as it adds support for qualified schema and table names. To this end, i
modified `validate_table` to parse (quoted) schema and table names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants