Fix file corruption in Electric.Utils.external_merge_sort() #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the input file is small enough to fit into a single chunk. The
problem is that File.stream!, by default, looks for line break
characters and normalizes any \r\n into \n when reading from the file.
So the data it writes into the target file is different from the one it
read from chunk_0 if it so happens that the latter has the sequence of
bytes <<13, 10>> in it.
The issue was reliably reproduced by running
mix test test/electric/utils_test.exs:30 --repeat-until-failure 1000
Co-authored-by: Garry Hill <garry@electric-sql.com>
alco
force-pushed
the
alco/external-merge-sort
branch
from
0654f1a to
f56eb3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input file is small enough to fit into a single chunk. The problem is that
File.stream!, by default, looks for line break characters and normalizes any\r\ninto\nwhen reading from the file. So the data it writes into the target file is different from the one it read from chunk_0 if it so happens that the latter has the sequence of bytes<<13, 10>>in it.