This repository has been archived by the owner on Mar 31, 2021. It is now read-only.
- adds support for localized electric emission factors #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @baywet - thanks for the PR. This looks really good, and is definitely an improvement over what we've done. The approach looks good to me. Let me know when you're ready for the final review and I'll make a final pass 👍 |
|
@corradio thanks for the feedback. I was actually wrapping up the PR.
This PR is ready to be merged whenever you have a chance :) |
corradio
reviewed
May 19, 2020
corradio
reviewed
May 19, 2020
|
@corradio thanks for merging! when do you think I'll see it on my phone? |
|
We'll try to make a release within next week! Stay tuned (or ask us on Slack) |
|
@corradio I just got the update on my phone and I saw the bubbles resizing and the progress bar updating live! Really cool! |
|
Great!
…On Thu, May 28, 2020 at 3:28 AM Vincent Biret ***@***.***> wrote:
@corradio <https://github.com/corradio> I just got the update on my phone
and I saw the bubbles resizing and the progress bar updating live! Really
cool!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#399 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMUIKENBOFDEZEBOJVXCALRTW447ANCNFSM4NDBD6JA>
.
--
Olivier Corradi
Founder, CEO
<https://www.linkedin.com/in/oliviercorradi> <https://twitter.com/corradio>
tmrow.com
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for country and state specific emission factors so the user's data can be more accurate.
It relies on the following data to work https://www.carbonfootprint.com/docs/2019_06_emissions_factors_sources_for_2019_electricity.pdf
I've only ported Canadian emission factors to get early feedback on the pull request before I invest too much time. We'd need to import the rest of the dataset.
Although the code is in place to support state specific, the library I'm using doesn't seem to support returning provinces/states at the moment. I have opened an issues over there to ask them if they are planning to add the information. rapideditor/country-coder#19
I made a point to use an offline library an not any API to avoid dependency on an API key and lengthy network calls that could slow down the app when importing data.
If they don't add that support, we could either look into other libraries to bridge the gaps or lookup by country only (less precise).
TODO: