Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(web): close map control tooltip when menu button is clicked #6813

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

tonypls
Copy link
Collaborator

@tonypls tonypls commented Jun 7, 2024

Issue

Currently our map button tooltips persist after a selection menu is opened

Description

This PR changes the pointer events for a map button depending on if it's a toggle button or a menu.

We want to tooltip to disappear when the menu is open

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only partially fixes the problem by hiding the tooltip if the menu is open but the original tooltip is still open while the mouse hovers on the icon (but disappear when moved outside).
image

@tonypls
Copy link
Collaborator Author

tonypls commented Jun 10, 2024

This only partially fixes the problem by hiding the tooltip if the menu is open but the original tooltip is still open while the mouse hovers on the icon (but disappear when moved outside). image

I can't seem to replicate this 🤔

@VIKTORVAV99
Copy link
Member

This only partially fixes the problem by hiding the tooltip if the menu is open but the original tooltip is still open while the mouse hovers on the icon (but disappear when moved outside). image

I can't seem to replicate this 🤔

And neither can I anymore...
Very strange but I guess this works as expected then?
I'll approve and then if the other things shows back up we'll handle it then.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@tonypls tonypls enabled auto-merge (squash) June 10, 2024 07:54
@tonypls tonypls merged commit f45e09f into master Jun 10, 2024
21 checks passed
@tonypls tonypls deleted the tvs/improve-map-control-tooltips branch June 10, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants