-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(translations): Clean up unused translations #6829
chore(translations): Clean up unused translations #6829
Conversation
@@ -134,7 +132,6 @@ | |||
}, | |||
"estimated_time_slicer_average": { | |||
"title": "Data är för närvarande uppskattad", | |||
"pill": "Otillgänglig", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should just add this key to the en file instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay to remove for now. We should re-add this with translations from "Preliminary" in the future, English also needs this for the badges in AVO-282. I'll add some context there
@@ -132,7 +132,6 @@ | |||
}, | |||
"estimated_time_slicer_average": { | |||
"title": "Os dados atuais são estimados", | |||
"pill": "Indisponível", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as for the Swedish one
BTW this can in theory be adapted to also run in CI to block any PRs that contain unused translation keys to prevent this in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's a little confusing now we have two en.json, nice work all the same!
Yeah and I think we should consider moving it directly to the API project but we can discuss that on a later point if we need to actually move it. |
Issue
We have some legacy translations that are not used anymore but still included in the language bundles which are bloating things.
Closes: AVO-322
Description
This PR adds a script to remove any key that are not in the
en.json
file from any of the other language files.It removes some translations from
en.json
that are no longer used.Runs the script.
Double check
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.