Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update production parser delay thresholds #6903

Conversation

florianscheidl
Copy link
Member

@florianscheidl florianscheidl commented Jun 26, 2024

Issue

For our alerting, we use zone-wise delay thresholds for their respective production parsers. However, for several zones, we have not computed this and therefore it does not appear in the zone config yet.

Description

In this PR, we add computed production parser delay thresholds for all zones.

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Jun 26, 2024
@florianscheidl florianscheidl marked this pull request as ready for review June 26, 2024 08:23
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Just curious how this is calculated though, like why is Norway at 7 hours delay when the expected delay from ENTSO-E is 2 hours?

@florianscheidl
Copy link
Member Author

florianscheidl commented Jun 26, 2024

It's something we are fine-tuning at the moment. I'm using a 0.75-quantile of measured delays and adding a 5-hour offset to ensure we don't get alerted right away for zones that have a slightly greater-than usual delay.

@florianscheidl florianscheidl merged commit e6f1fe5 into master Jun 26, 2024
20 checks passed
@florianscheidl florianscheidl deleted the florianscheidl/pla-1261-update-production-parser-threshold-delay-for-all-zones branch June 26, 2024 12:17
@VIKTORVAV99
Copy link
Member

It's something we are fine-tuning at the moment. I'm using a 0.75-quantile of measured delays and adding a 5-hour offset to ensure we don't get alerted right away for zones that have a slightly greater-than usual delay.

Sounds great!

However I'm wondering if it doesn't make more sense to just keep the offset in the function that alerts us rather than inside the config themselves? But that's just a minor implementation detail really.

@florianscheidl
Copy link
Member Author

Good point, we might want to move towards that in the future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants