feat: include timezone in hourly displays

[VIKTORVAV99]

Description

Adds timezones to hourly time displays to reduce confusion in shared screenshots and the like.

Preview

On master:

SV:

EN:

On this branch:

SV:

EN:

Double check

• I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

[silkeholmebonnen]

Nice work! One optional suggestion:)

[silkeholmebonnen]

I just noticed this! Can you create a follow up PR to fix it?
Or maybe it's a good time to move the dates on tooltips now? AVO-95

[VIKTORVAV99]

I just noticed this! Can you create a follow up PR to fix it? Or maybe it's a good time to move the dates on tooltips now? AVO-95

Ah!
I'll pull the ripcord on AVO-95 and do that tomorrow.

[madsnedergaard]

I think we should have been a bit more thorough on checking all cases where a date is present 😅

[VIKTORVAV99]

I think we should have been a bit more thorough on checking all cases where a date is present 😅

This tooltip will soon get a revamp as well...
But yes we probably should have been more careful about this change, visually.

[madsnedergaard]

Did you try/consider using date-fns or dayjs with AdvancedFormat to display dates in a shorter way?

[VIKTORVAV99]

Did you try/consider using date-fns or dayjs with AdvancedFormat to display dates in a shorter way?

Since we don't use dayjs I'm not super keen on replacing every date-fns function with it. Cause having two date time libraries makes no sense. And with date-fns we need to import all the locales separately (it's built to be as tiny as possible) and I think they would format things roughly the same.

In theory we can build or own locale with Intl and control the format more tightly but I simply don't think it's worth it.

Especially since the tooltips themselves are the problem as they have not been migrated to the new design yet.

[madsnedergaard]

Did you try/consider using date-fns or dayjs with AdvancedFormat to display dates in a shorter way?

Since we don't use dayjs I'm not super keen on replacing every date-fns function with it. Cause having two date time libraries makes no sense. And with date-fns we need to import all the locales separately (it's built to be as tiny as possible) and I think they would format things roughly the same.

In theory we can build or own locale with Intl and control the format more tightly but I simply don't think it's worth it.

Especially since the tooltips themselves are the problem as they have not been migrated to the new design yet.

I think it's a larger problem than just tooltips, but happy to discuss it separately at another time :)

This is on MacOS 14" with Arc:

And this is in full-width on an external display: