Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): re-enable price for nordpool zones #6952

Merged

Conversation

tonypls
Copy link
Collaborator

@tonypls tonypls commented Jul 4, 2024

Issue

We had to remove price data for Nordpool zones!

Description

This PR removes the filtering flags for price data that we previously didn't have the licensing to share. We've now purchased the license and can re-enable this feature 🎉

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Jul 4, 2024
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we also have to change the source values or is it enough that we have the license?

@madsnedergaard
Copy link
Member

Should we coordinate some SoMe content when releasing this? :)

@tonypls
Copy link
Collaborator Author

tonypls commented Jul 4, 2024

Do you know if we also have to change the source values or is it enough that we have the license?

Good question, I think the source is still ENTSOE but the source of the source is Nordpool. It's probably better to use Nordpool 🤔

@tonypls
Copy link
Collaborator Author

tonypls commented Jul 4, 2024

Should we coordinate some SoMe content when releasing this? :)

Good idea! We might be able to turn around some negative app reviews too. I've made issues here AVO-374 AVO-375

@VIKTORVAV99
Copy link
Member

Do you know if we also have to change the source values or is it enough that we have the license?

Good question, I think the source is still ENTSOE but the source of the source is Nordpool. It's probably better to use Nordpool 🤔

We don't actually say the source for the price data in the app yet so I guess we could either skip it or hardcode it for now.

I think the ENTSO-E license also allows us to use it as long as we have the Nordpool license as well.

@tonypls tonypls enabled auto-merge (squash) July 4, 2024 11:43
@tonypls tonypls merged commit 8601622 into master Jul 4, 2024
18 checks passed
@tonypls tonypls deleted the tonyvanswet/avo-373-turn-off-filtering-of-noorpool-price-zones branch July 4, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants