Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to react-i18next 15 #6989

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

VIKTORVAV99
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 commented Jul 17, 2024

Description

I have made som upstream changes in react-i18next to reduce the code size a bit and make it slightly more performant. Coupled with #6891 this should give us a nice size reduction (it's already cutting the size by 1kb without it).

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added frontend 🎨 dependencies Pull requests that update a dependency file labels Jul 17, 2024
@VIKTORVAV99 VIKTORVAV99 marked this pull request as draft July 17, 2024 14:42
@VIKTORVAV99 VIKTORVAV99 marked this pull request as ready for review July 18, 2024 12:48
@VIKTORVAV99 VIKTORVAV99 requested review from a team and silkeholmebonnen and removed request for a team July 18, 2024 12:48
Copy link
Contributor

@silkeholmebonnen silkeholmebonnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) July 19, 2024 15:23
@VIKTORVAV99 VIKTORVAV99 merged commit 3b2cb81 into master Jul 19, 2024
20 checks passed
@VIKTORVAV99 VIKTORVAV99 deleted the vik/react-i18next_v15 branch July 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend 🎨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants