perf: use useCallbacks for handlers and deconstruct events #7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
requested review from
a team and
madsnedergaard
and removed request for
a team
VIKTORVAV99
requested review from
tonypls
and removed request for
madsnedergaard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The handlers are not wrapped in useCallbacks and are re-created on each render.
Description
Wraps the handlers in useCallbacks to avoid recreating them and deconstructs the event objects to optimize the size a bit.
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.