fix: persist ranking on search #7048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonypls
approved these changes
Aug 21, 2024
I have a few things to follow up on this (like searching in English should always work no matter the language) so I can add that as well. |
|
looks like solved: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The ranking panel used the index as the ranking but this always changed when searching in meaning if you searched a single zone it would always be ranked as 1.
Description
This PR rewrites the whole filtering and sorting logic to account for this and persist the ranking even in searches, something that it looked like it was always intended to do as there was already a ranking property that was always set to undefined.
As a bonus it will now also match using the zone key.
This should partially help with the issue described in #6971
TODO:
Preview
On master
On this branch
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.