Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Lucide icons for Onboarding and refractor code #7084

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

VIKTORVAV99
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 commented Aug 16, 2024

Issue

We don't use Lucide icons in the onboarding and the DOM is overly complex and duplicates code.

Part of: AVO-439

Description

Uses Lucide icons, switches to use the <Button /> component and cleans up the logic a bit.

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

Copy link
Contributor

@silkeholmebonnen silkeholmebonnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, but looks good!

web/src/components/modals/OnboardingModal.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@silkeholmebonnen silkeholmebonnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) August 19, 2024 09:27
@VIKTORVAV99 VIKTORVAV99 merged commit d9efd18 into master Aug 19, 2024
21 checks passed
@VIKTORVAV99 VIKTORVAV99 deleted the vik/onboarding_lucide_icons branch August 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 🎨 techdebt Unpleasantness that does (or may in future) affect development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants