chore: use Lucide icons in DataSources and simplify DOM #7086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
changed the title
VIKTORVAV99
commented
Aug 17, 2024
| <button className="p-auto pointer-events-auto mt-2 flex h-10 w-10 items-center justify-center self-center rounded-full border bg-zinc-50 text-black shadow-md"> | ||
| <X /> | ||
| </button> | ||
| <Button icon={<X />} type="secondary" backgroundClasses="pointer-events-auto" /> |
There was a problem hiding this comment.
@Alportan I know we have discussed this button before (the white button) but I decided to switch it to use the button component here and therefore it will follow the theme.
I think it should be fine as it has an outline and it will help with keeping things uniform as other tooltips don't have this white icon.
I will also switch other tooltips to use the button component so it's uniform in both style and functionality.
VIKTORVAV99
added
the
techdebt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We were not using Lucide icons for all of the icons here.
Part of: AVO-439
Description
Switches to use Lucide icons.
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.