Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zone-config): update discharge emission factors for US-CAL-CISO #7093

Conversation

silkeholmebonnen
Copy link
Contributor

Issue

AVO-208

Description

This PR updates the discharge emission factors for US-CAL-CISO. The updated script was used to make these changes.

Preview

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Aug 20, 2024
@silkeholmebonnen
Copy link
Contributor Author

Should I do wait on doing this for all zones until the emission factor work has been merged? @VIKTORVAV99

@VIKTORVAV99
Copy link
Member

Should I do wait on doing this for all zones until the emission factor work has been merged? @VIKTORVAV99

If you want you can do all for 2022 and before. Then we can do 2023 after we have merged the emission factors.

Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a US zone and we're only updating emission factors for EU in #7155, I think it's fine to go ahead with this :)

@silkeholmebonnen silkeholmebonnen enabled auto-merge (squash) September 10, 2024 13:38
@silkeholmebonnen silkeholmebonnen merged commit f22e432 into master Sep 10, 2024
20 checks passed
@silkeholmebonnen silkeholmebonnen deleted the silkebonnen/avo-208-update-battery-emission-factors-for-zones-where-batteries branch September 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants