Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translations #7094

Merged
merged 4 commits into from
Aug 20, 2024
Merged

French translations #7094

merged 4 commits into from
Aug 20, 2024

Conversation

phiphou
Copy link
Contributor

@phiphou phiphou commented Aug 20, 2024

Add some french translations.

I discussed #7091 with french lovers of the project via Twitter DMs, and we came to a better solution.

Using the "via" word offers a better translation than the "par" word.

So this PR translate "comes from solar" by "est générée via solaire".

It don't totaly fix it, the "multiple keys for each energy source" is still the best in my opinion.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Cool that you where able to iterate it that quickly! 🚀

@VIKTORVAV99 VIKTORVAV99 merged commit 26e758e into electricitymaps:master Aug 20, 2024
21 checks passed
@phiphou
Copy link
Contributor Author

phiphou commented Aug 20, 2024

In french, we say "quand c'est fait c'est plus à faire", wich means "when it's done, you don't have to do it anymore" ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants