-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Lucide icons instead of SVG backgrounds and simplify DOM #7101
Conversation
ackgrounds
This comment was marked as resolved.
This comment was marked as resolved.
@Alportan this is the PR that uses the new Lucide icon you added, however the Figma seems to miss the replacement icon for the aggregated card (the one on top if you switch to daily, monthly or yearly) so I just picked one of the graph icons without the axis. Could you double check this one? |
Good catch, I think the graph icon looks great! 🙌
I have a few comments, that now, with the new icons, the icon gets really close to the card title. Additionally, can we use the same icon as we do on the card on the |
As discussed in Slack I tweaked the style changes. For fixing the preliminary I'll do that in a follow up PR (It's already in the works) to keep the scope of this PR mostly to the icons themselves and not so much the logic around them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🙌
Issue
We were using SVG background instead of Icon components.
Description
Removes the SVG backgrounds and replaces them with Lucide icons. It also further simplifies the DOM and styling of the Accordion component to fix a title overflow issue in some languages.
Double check
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.