-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solar
and unknown
capacity for Hungary
#7102
Update solar
and unknown
capacity for Hungary
#7102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thanks for your contribution!
Some small notes but the values themselves look good.
config/zones/HU.yaml
Outdated
- datetime: '2024-01-01' | ||
source: entsoe.eu | ||
value: 3552.0 | ||
- datetime: '2024-08-01' | ||
source: entsoe.eu | ||
value: 3688.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update the value for 2024-01-01 here instead as ENTSO-E only have yearly capacity data.
This is so it's consistent with any updates in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That just says when it was last updated, not when the capacity actually was installed (which is the issue here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config/zones/HU.yaml
Outdated
- datetime: '2024-01-01' | ||
source: entsoe.eu | ||
value: 97.0 | ||
- datetime: '2024-08-01' | ||
source: entsoe.eu | ||
value: 106.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And same here.
6574d62
to
d3468cc
Compare
I've made the date changes as requested, but IMHO this is not correct, and will be even less so in a week or so (and so on every month until next year). |
@FelixDQ what is your take on this? It affect you guys more than it does the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7b8454f
to
d7b6c2e
Compare
I have deduced that "Waste" also counts as
biomass
(but capacities are unchanged) and thatunknown
is "Other" + "Other renewable".[source]