Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solar and unknown capacity for Hungary #7102

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

torokati44
Copy link
Contributor

I have deduced that "Waste" also counts as biomass (but capacities are unchanged) and that unknown is "Other" + "Other renewable".

[source]

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Aug 23, 2024
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for your contribution!

Some small notes but the values themselves look good.

Comment on lines 45 to 47
- datetime: '2024-01-01'
source: entsoe.eu
value: 3552.0
- datetime: '2024-08-01'
source: entsoe.eu
value: 3688.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the value for 2024-01-01 here instead as ENTSO-E only have yearly capacity data.

This is so it's consistent with any updates in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I added a new entry with a new date:
image

Should I still do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That just says when it was last updated, not when the capacity actually was installed (which is the issue here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind making the change, just as another point of reference:
Screenshot_20240823-151102

Source: https://mavir.hu/documents/10258/278599663/PV+STATISZTIKA_20240801-ig_v1_HU.pdf/6e1de413-b078-4532-c1ea-8e60ddc75ecb?t=1723627018428

The current value of 3552.0 seems to be from May FWIW.

Comment on lines 55 to 54
- datetime: '2024-01-01'
source: entsoe.eu
value: 97.0
- datetime: '2024-08-01'
source: entsoe.eu
value: 106.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And same here.

@torokati44
Copy link
Contributor Author

I've made the date changes as requested, but IMHO this is not correct, and will be even less so in a week or so (and so on every month until next year).

@VIKTORVAV99
Copy link
Member

@FelixDQ what is your take on this? It affect you guys more than it does the app.

Copy link
Member

@FelixDQ FelixDQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VIKTORVAV99 VIKTORVAV99 merged commit 8e6e2de into electricitymaps:master Aug 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants