Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translation): Remove hardcoded string in favour of translation strings #7108

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

VIKTORVAV99
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 commented Aug 26, 2024

Issue

We had a hardcoded sting that could not be translated.

Description

Fixes the above issue.

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

Copy link
Contributor

@silkeholmebonnen silkeholmebonnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇺🇸 🇸🇪

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) August 26, 2024 08:31
@VIKTORVAV99 VIKTORVAV99 merged commit 9213034 into master Aug 26, 2024
21 checks passed
@VIKTORVAV99 VIKTORVAV99 deleted the vik/remove_hardcoded_translation branch August 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants